-
-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(27254): implement new remote-feature-flag-controller #4931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DDDDDanica
force-pushed
the
feature/27254-feature-flag-controller
branch
6 times, most recently
from
November 15, 2024 03:13
78af7f4
to
cd93f7a
Compare
No dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No dependency changes detected in pull request |
DDDDDanica
force-pushed
the
feature/27254-feature-flag-controller
branch
from
November 16, 2024 03:42
cd93f7a
to
82f7997
Compare
DDDDDanica
force-pushed
the
feature/27254-feature-flag-controller
branch
2 times, most recently
from
November 19, 2024 11:53
78ca22b
to
a7a3cf1
Compare
DDDDDanica
force-pushed
the
feature/27254-feature-flag-controller
branch
9 times, most recently
from
November 20, 2024 12:19
0519340
to
fcc71a0
Compare
@metamaskbot publish-preview |
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions.
|
DDDDDanica
force-pushed
the
feature/27254-feature-flag-controller
branch
6 times, most recently
from
November 21, 2024 21:20
153ebc9
to
0fab160
Compare
…atureFlags (plural) and clean up a couple of tests
… it no longer returns feature flags
DDDDDanica
force-pushed
the
feature/27254-feature-flag-controller
branch
from
November 28, 2024 18:19
040a495
to
791fd6f
Compare
Gudahtt
approved these changes
Nov 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
danjm
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Following the ADR here
Adds a new controller,
remote-feature-flag-controller
that fetches the remote feature flags and provide cache solution for consumers.References
Related to #27254
Changelog
@metamask/remote-feature-flag-controller
ADDED: Initial release
Checklist