Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(27254): implement new remote-feature-flag-controller #4931

Merged
merged 37 commits into from
Nov 28, 2024
Merged

feat(27254): implement new remote-feature-flag-controller #4931

merged 37 commits into from
Nov 28, 2024

Conversation

DDDDDanica
Copy link
Contributor

@DDDDDanica DDDDDanica commented Nov 14, 2024 •
edited
Loading

Explanation

Following the ADR here

Adds a new controller, remote-feature-flag-controller that fetches the remote feature flags and provide cache solution for consumers.

References

Related to #27254

Changelog

@metamask/remote-feature-flag-controller

ADDED: Initial release

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@DDDDDanica DDDDDanica force-pushed the feature/27254-feature-flag-controller branch 6 times, most recently from 78af7f4 to cd93f7a Compare November 15, 2024 03:13
@socket-security Socket Security
Copy link

socket-security bot commented Nov 15, 2024 •
edited
Loading

No dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No dependency changes detected in pull request

@DDDDDanica DDDDDanica force-pushed the feature/27254-feature-flag-controller branch from cd93f7a to 82f7997 Compare November 16, 2024 03:42
@DDDDDanica DDDDDanica self-assigned this Nov 16, 2024
@DDDDDanica DDDDDanica force-pushed the feature/27254-feature-flag-controller branch 2 times, most recently from 78ca22b to a7a3cf1 Compare November 19, 2024 11:53
@DDDDDanica DDDDDanica marked this pull request as ready for review November 19, 2024 23:04
@DDDDDanica DDDDDanica requested a review from a team as a code owner November 19, 2024 23:04
@DDDDDanica DDDDDanica force-pushed the feature/27254-feature-flag-controller branch 9 times, most recently from 0519340 to fcc71a0 Compare November 20, 2024 12:19
@DDDDDanica
Copy link
Contributor Author

@metamaskbot publish-preview

@github-actions GitHub Actions
Copy link
Contributor

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions. 
{
  "@metamask-previews/accounts-controller": "19.0.0-preview-fcc71a0",
  "@metamask-previews/address-book-controller": "6.0.1-preview-fcc71a0",
  "@metamask-previews/announcement-controller": "7.0.1-preview-fcc71a0",
  "@metamask-previews/approval-controller": "7.1.1-preview-fcc71a0",
  "@metamask-previews/assets-controllers": "44.0.1-preview-fcc71a0",
  "@metamask-previews/base-controller": "7.0.2-preview-fcc71a0",
  "@metamask-previews/build-utils": "3.0.1-preview-fcc71a0",
  "@metamask-previews/chain-controller": "0.1.3-preview-fcc71a0",
  "@metamask-previews/composable-controller": "9.0.1-preview-fcc71a0",
  "@metamask-previews/controller-utils": "11.4.3-preview-fcc71a0",
  "@metamask-previews/ens-controller": "15.0.0-preview-fcc71a0",
  "@metamask-previews/eth-json-rpc-provider": "4.1.6-preview-fcc71a0",
  "@metamask-previews/gas-fee-controller": "22.0.1-preview-fcc71a0",
  "@metamask-previews/json-rpc-engine": "10.0.1-preview-fcc71a0",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.5-preview-fcc71a0",
  "@metamask-previews/keyring-controller": "18.0.0-preview-fcc71a0",
  "@metamask-previews/logging-controller": "6.0.2-preview-fcc71a0",
  "@metamask-previews/message-manager": "11.0.1-preview-fcc71a0",
  "@metamask-previews/multichain": "0.0.0-preview-fcc71a0",
  "@metamask-previews/name-controller": "8.0.1-preview-fcc71a0",
  "@metamask-previews/network-controller": "22.0.2-preview-fcc71a0",
  "@metamask-previews/notification-controller": "7.0.0-preview-fcc71a0",
  "@metamask-previews/notification-services-controller": "0.13.0-preview-fcc71a0",
  "@metamask-previews/permission-controller": "11.0.3-preview-fcc71a0",
  "@metamask-previews/permission-log-controller": "3.0.1-preview-fcc71a0",
  "@metamask-previews/phishing-controller": "12.3.0-preview-fcc71a0",
  "@metamask-previews/polling-controller": "12.0.1-preview-fcc71a0",
  "@metamask-previews/preferences-controller": "14.0.0-preview-fcc71a0",
  "@metamask-previews/profile-sync-controller": "1.0.2-preview-fcc71a0",
  "@metamask-previews/queued-request-controller": "7.0.1-preview-fcc71a0",
  "@metamask-previews/rate-limit-controller": "6.0.1-preview-fcc71a0",
  "@metamask-previews/selected-network-controller": "19.0.0-preview-fcc71a0",
  "@metamask-previews/signature-controller": "22.0.0-preview-fcc71a0",
  "@metamask-previews/transaction-controller": "39.0.0-preview-fcc71a0",
  "@metamask-previews/user-operation-controller": "18.0.0-preview-fcc71a0"
}

@DDDDDanica DDDDDanica force-pushed the feature/27254-feature-flag-controller branch 6 times, most recently from 153ebc9 to 0fab160 Compare November 21, 2024 21:20
danjm and others added 24 commits November 28, 2024 18:19
@danjm @DDDDDanica
Pluralize remoteFeatureFlag within remote-feature-flag-controller.* f…
3ba6395 
…iles
@danjm @DDDDDanica
Lint fix
8fcae88
@danjm @DDDDDanica
Update descriptions in readme and package.json
1392957
@danjm @DDDDDanica
Update license to use MIT and Apache 2
b5278f5
@danjm @DDDDDanica
Return cached data if disabled is true; complete renaming to remoteFe…
fe1b382 
…atureFlags (plural) and clean up a couple of tests
@danjm @DDDDDanica
Lint package.json
5d682a9
@danjm @DDDDDanica
Validate that data returned by the API in fetchRemoteFeatureFlags is …
3b55e9e 
…an array
@danjm @DDDDDanica
Add name property to feature flag objects
d0b6b8e
@danjm @DDDDDanica
Lint package.json
f671453
@danjm @DDDDDanica
Remove use of deferred promise in getRemoteFeatureFlags
0e5f507
@danjm @DDDDDanica
Clean up lint and tests
041cbff
@DDDDDanica
feat(27254): fix line issue in test file
de16e16
@DDDDDanica
feat(27254): increase jest threshold
be6ea29
@DDDDDanica
feat(27254): create a LICENSE file that references both licenses:
759fe89
@danjm @DDDDDanica
Re-add call to updateCache and update unit tests to verify that updat…
af8efcf 
…eCache is called
@DDDDDanica
feat(27254): flattern data from service side
1a0eb16
@danjm @DDDDDanica
Refactor getRemoteFeatureFlags to updateRemoteFeatureFlags, such that…
389d115 
… it no longer returns feature flags
@danjm @DDDDDanica
Use # instead of private in remoteFeatureFlagsController
df86c38
@DDDDDanica
feat(27254): flattern data applied to controller
cbeb4ae
@DDDDDanica
feat(27254): increase test coverage
0517f57
@DDDDDanica
feat(27254): modify test names to fit new patter
8ef4534
@DDDDDanica
feat(27254): lint fix
96ddeb9
@DDDDDanica
feat(27254): export in types
0a0a118
@DDDDDanica
feat(27254): remove unneeed api response
791fd6f
@DDDDDanica DDDDDanica force-pushed the feature/27254-feature-flag-controller branch from 040a495 to 791fd6f Compare November 28, 2024 18:19
Gudahtt
Gudahtt approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@DDDDDanica DDDDDanica merged commit 848395d into main Nov 28, 2024
123 checks passed
@DDDDDanica DDDDDanica deleted the feature/27254-feature-flag-controller branch November 28, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcmire mcmire mcmire left review comments

@danjm danjm danjm approved these changes

@Gudahtt Gudahtt Gudahtt approved these changes

@joaoloureirop joaoloureirop joaoloureirop left review comments

Assignees

@DDDDDanica DDDDDanica

Labels
None yet
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@DDDDDanica @danjm @Gudahtt @mcmire @joaoloureirop